]> dgit.raspbian.org Git - gnome-shell.git/commit
Make sure to allocate all children in allocate vfuncs
authorJonas Dreßler <verdre@v0yd.nl>
Sat, 24 Oct 2020 18:25:49 +0000 (20:25 +0200)
committerMarge Bot <marge-bot@gnome.org>
Tue, 24 Nov 2020 20:20:45 +0000 (20:20 +0000)
commit3fb0284358714ba72d586b918783ddead05a09f8
tree6efc68d6366c22afd4ee576f3aa22dd488b9434a
parente8893f4fa4718ad5ca89d03f27b5d12d09733bae
Make sure to allocate all children in allocate vfuncs

Clutter expects actors overriding the allocate vfunc to allocate all
mapped children of the actor, otherwise bad things happen.

So make sure we actually allocate all our visible children in our custom
allocation functions, and since we don't want to give them a real
allocation, just pass them an empty ClutterActorBox.

It would be nice if we had a way to hide children during the allocation
process where no relayout is queued like gtk allows with
gtk_widget_set_child_visible(), then we could avoid those weird empty
ClutterActorBoxes.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3098

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1481>
js/ui/search.js
js/ui/userWidget.js
js/ui/workspace.js
js/ui/workspaceThumbnail.js